Why Code Snobs Are Invaluable
Some argue that “code snobs” waste time on trivia. While I am sure this can be the case, I submit that their ideas and comments offer more benefit than cost in the long run.
The engineer that I had requested for the code review—who had recently reworked our Selenium testing framework and is an active proponent of code quality for our team—left a comment on our pull request system for a particular area of the code I was submitting. He suggested a slight change, merely that some of the classes I had implemented were not using the singleton pattern, while some of their analogous counterparts were, and that I should adjust them to better mirror that structure.
I was halfway through replying to the comment with reasons to just move forward and approve my pull request anyway when I realized that he was right. The classes really would be more semantic if they were singletons. I decided to take the additional 15 minutes to make the change.
Perhaps a “code snob” is simply the term lazy programmers use to describe their more disciplined peers. If that’s the case, I want to be one.